Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: monospace inline link needs styles #288

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: monospace inline link needs styles #288

merged 1 commit into from
Jan 2, 2024

Conversation

wesleyboar
Copy link
Member

Overview

Style monospace text (<code>, <kbd>, etc.) that are within a link (<a>).

Related

Changes

  • added styles for linked monospace elements

Testing

  1. Open http://localhost:3000/components/detail/monospace--docs.
  2. See "A sentence with code (<code>) snippet, and as a link."
  3. See "A sentence with code (<code>) with keyboard input, and as a link."
  4. Verify linked monospace text is styled differently than non-link monospace text.
  5. Verify link styles change upon interaction (hover, click, focus).

UI

fix monospace links
fix.monospace.links.mov

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Jan 2, 2024
@wesleyboar wesleyboar added patch A backward-compatible fix and removed fix Fixes user-facing behavior or feature labels Jan 2, 2024
@wesleyboar wesleyboar merged commit f1b9a13 into main Jan 2, 2024
4 of 7 checks passed
@wesleyboar wesleyboar deleted the fix/monospace-inline-link-needs-style branch January 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar