-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fp-1499 ui pattern demo #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2022
TACC/tup-ui@a30002a TACC/tup-ui@24db51b TACC/tup-ui@141464f P.S. a30002a originates from TACC/tup-ui#38
25d184d
to
5803ef7
Compare
Retiring this repo in favor of https://github.com/TACC/tup-ui. |
No need for `-css` on build and test scripts.
1 task
rstijerina
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
npm start
command to demo core-styles patterns (using Fractal).This demo lets us prove CSS modules work before a client* uses them.
* Clients are core-components, Core-CMS, Core-Portal, and future external parties.
To Do
Related
required by task/FP-1499: CMS pattern library Core-CMS#512required by Task/fp 1499 ui pattern demo Core-CMS#527
mimics Task/fp 1499 core-styles pattern demo tup-ui#28Changes
.gitignore
demo outputbuild
script intobuild:css
andbuild:demo
Testing
npm ci
npm run build:css
npm run start
UI of patterns in demo match Portal UI for the same pattern.﹡
(bonus) Test CMS UI Demo.†
task/fp-1499-ui-pattern-demo--fp-1726-publications-list
﹡ See screenshots in "UI" section.
† The CMS (or any client) can apply its styles atop the core-styles demo.
UI
Fixes
no italics for pseudo-icons (474eff3)