Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(c-button): fp-1791 auto width by default #49

Merged
merged 3 commits into from
Oct 31, 2022
Merged

fix(c-button): fp-1791 auto width by default #49

merged 3 commits into from
Oct 31, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 28, 2022 •
edited
Loading

Overview

Buttons should be automatic width by default.

Related

Changes

  • Do not default width to short.
  • Do not set font size (let client do so, or not).

Testing

Pages:

Steps:

  1. Submit buttons are as wide as their text content (plus padding).
  2. Submit buttons width is not fixed by a snippet.

UI

Tested via consumer app; see TACC/Core-CMS#560.

@wesleyboar wesleyboar mentioned this pull request Oct 28, 2022
Merged
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Oct 28, 2022
@wesleyboar
feat: fp-1791 auto-width buttons from core-styles
f27c67b 
TACC/Core-Styles#49
wesleyboar and others added 2 commits October 28, 2022 21:44
@wesleyboar
fix(c-button): fp-1911 fp-1791 font size
98cdc10 
- Do NOT set font-size of buttons in core styles.
- Let font size:
    - either be inherited (Bootstrap _reboot.css)
    - or be set by client (portal, cms, tup)
@wesleyboar
Merge branch 'main' into fix/fp-1791-automatic-button-width
081554f
@wesleyboar wesleyboar merged commit 2b44038 into main Oct 31, 2022
@wesleyboar wesleyboar deleted the fix/fp-1791-automatic-button-width branch October 31, 2022 20:52
@wesleyboar wesleyboar restored the fix/fp-1791-automatic-button-width branch October 31, 2022 20:52
@wesleyboar
Copy link
Member Author

⚠️ Branch restored (temporarily) so if TACC/Core-CMS#560 merge pushes a new CMS image to https://hub.docker.com/r/taccwma/core-cms/tags, then npm ci will locate this branch from which it is told to install core styles.

@wesleyboar wesleyboar deleted the fix/fp-1791-automatic-button-width branch November 8, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar