Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c-button): do not show <a> tag button for --as-link #59

Merged
merged 2 commits into from
Nov 11, 2022
Merged

feat(c-button): do not show <a> tag button for --as-link #59

merged 2 commits into from
Nov 11, 2022

Conversation

wesleyboar
Copy link
Member

Overview

Show <a> tag use of c-button, unless button is type c-button--as-link.

Related

N/A

Changes

  • add supports.link-tag context boolean
  • use new context boolean to show <a> tag for most c-button states

Testing

  1. git checkout
  2. npm run build:css
  3. npm start
  4. Navigate to Components > C-Button > Primary.
  5. Verify <a> examples are shown.
  6. Navigate to Components > C-Button > As Link.
  7. Verify <a> examples are not shown.

UI

Primary As Link
Primary As Link

@wesleyboar wesleyboar merged commit 5e9b252 into main Nov 11, 2022
@wesleyboar wesleyboar deleted the task/c-button-to-not-show-a-tag-for-as-link branch November 11, 2022 16:43
@wesleyboar wesleyboar mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar