Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): c-form & django-cms-forms, now wip status #80

Merged
merged 66 commits into from
Dec 2, 2022

Commits on Nov 21, 2022

  1. feat(base): (root), cms, portal, header, updates

    Also:
    - add MuiTab use case to bootstrap.modal
    - add MuiTab stylesheet for portal
    - remove outdated icon trump files
    - add base stylesheets for clients to load
    
    Client should always load base.css first.
    
    | stylesheet      | root¹ | cms² | portal³ | header ⁴ |
    | -               |   -   |  -   |    -    |    -     |
    | base.css        |   ✓   |  —   |    —    |    —     |
    | base.cms.css    |   —   |  ✓   |    —    |    —     |
    | base.portal.css |   —   |  —   |    ✓    |    —     |
    | base.header.css |   —   |  —   |    —    |    ✓     |
    
    There may be a base.docs.css after TUP-264.
    
    ¹ everything except cms, portal, and header
    ² e.g. cms
    ³ e.g. cepv2, tup-ui
    ⁴ e.g. cms, cepv2, frontera-tech-docs
    wesleyboar committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    f695ad1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1997b8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17e459c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d02c0d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. fix: rename base.*.css to core-styles.*.css

    | stylesheet | root¹ | cms² | portal³ | header ⁴ |
    | - | - | - | - | - |
    | core-styles.base.css | ✓ | — | — | — |
    | core-styles.cms.css | — | ✓ | — | — |
    | core-styles.portal.css | — | — | ✓ | — |
    | core-styles.header.css | — | — | — | ✓ |
    
    There may be a core-styles.docs.css after TUP-264.
    
    ¹ everything except cms, portal, and header
    ² e.g. cms
    ³ e.g. cepv2, tup-ui
    ⁴ e.g. cms, cepv2, frontera-tech-docs
    wesleyboar committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    8bb41c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2ff5a4 View commit details
    Browse the repository at this point in the history
  3. fix(core-styles): header trump cms when layered

    With layers, core-styles.header.css must overwrite core-styles.cms.css.
    
    Sans layers, site.header.css relied on bootstrap to override site.css.
    wesleyboar committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    0ee442a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc108df View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    44dee14 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    17a5c25 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    015bca7 View commit details
    Browse the repository at this point in the history
  8. fix(core-styles): avoid duplicate custom prop defs

    Avoid dupllicate custom property (a.k.a. variable) definitions in:
    - `.core-styles.cms.css`
    - `.core-styles.header.css`
    wesleyboar committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    3a0cce0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    566ee9d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    abc5e9f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    29c5f63 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Configuration menu
    Copy the full SHA
    1a8df00 View commit details
    Browse the repository at this point in the history
  2. wip(form): elements, components, relevant changes

    - some changes may be for main branch
    - some changes may be for task/base-cms-portal-header branch
    
    1. testing pattern for Core-CMS djangco.cms.forms
    2. new c-form component & pattern needs template
    3. just begining form.cms pattern
    4. update s-affixed-input-… accordingly (for: 2, 3)
    4. initial change of partials to use core-styles.*.css
    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    1cbc279 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c56ad2d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    849e9c9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    97807e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c471d84 View commit details
    Browse the repository at this point in the history
  7. wip(form): elements, components, relevant changes

    - some changes may be for main branch
    - some changes may be for task/base-cms-portal-header branch
    
    1. testing pattern for Core-CMS djangco.cms.forms
    2. new c-form component & pattern needs template
    3. just begining form.cms pattern
    4. update s-affixed-input-… accordingly (for: 2, 3)
    4. initial change of partials to use core-styles.*.css
    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c607adc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b34166d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3097b77 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    01932d3 View commit details
    Browse the repository at this point in the history
  11. docs(form): tweaks

    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    89d77a6 View commit details
    Browse the repository at this point in the history
  12. fix(components): django-cms-forms pattern (cms)

    This is for CMS, but was being tested here. it works now.
    
    Latest real bug was misssing the .html extension inthe demo.
    
    This pattern was just committed in TACC/Core-CMS:
    - task/get-core-styles-beyond-0.11.0
    - d13ca50
    
    I am porting the polishes and fixes here just so that when I delete I am deleting at the time at which CMS resumes control of it.
    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b336a48 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    243aceb View commit details
    Browse the repository at this point in the history
  14. fix!: avoid redundant custom property definitions

    - build
    - removed import of settings by src/_imports files
    - added `core-styles.settings.css`
    - changed demo to always load `core-styles.settings.css` up front
    
    BREAKING CHANGE: Clients must include `settings.css` OR `base.css` e.g.
    - @import url('@tacc/core-styles/dist/core-styles.settings.css')
    - @import url('@tacc/core-styles/dist/core-styles.base.css')
    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ca1b35d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ca3f568 View commit details
    Browse the repository at this point in the history
  16. fix(demo): load core-styles.base via config

    Loading manually meant clients were forced to build off of it. But clients may include core-styles.base along with other files and want to configure that to load. Without this change, and with a client doing that, the client receives duplicate (hard to track down) css.
    wesleyboar committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    436995b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c60d40c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. fix(demo): core-styles.base from absolute path

    This allowed npx serve and npm start to both load the file.
    wesleyboar committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    5e2fd8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e52133 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfe93de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db8fec4 View commit details
    Browse the repository at this point in the history
  5. fix(fonts)!: support font load on demo

    All clients must change font path replacement assumption:
    - before, dist had ../fonts
    - after, dist has ./fonts
    wesleyboar committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    e653718 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    d51af9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e3d54f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e8a600d View commit details
    Browse the repository at this point in the history
  4. wip(form): c-form & html-elements

    - build dist
    - changed c-form.hbs to use c-form markup
    - changed django-cms-forms to not load bootstrap
    - changed django-cms-forms to load component
    - removed extra stuff from django-cms-forms.hbs
    - fixed selector `:not` syntax in c-forms.css
    - fixed message font-weight in django-cms-form-hacks.css
    - removed outdated docs comment from django-cms-forms.css
    - fixed URL copy-pasta in elements/form.cms
    - added html-elements.css (for base)
    - changed ….base.css to load html-elements.css
    wesleyboar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0b3e4e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8eb54d2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c2f4fd2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e551b95 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f430104 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f156361 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d664919 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    067540c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9f7f08e View commit details
    Browse the repository at this point in the history
  13. feat(demo): pattern script assets must be modules

    Without this, modules jsut don't work. Better to use modules than not.
    wesleyboar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4a483ef View commit details
    Browse the repository at this point in the history
  14. feat(components): forms, toggle required & errors

    Allow form aptterns to have buttons that
    - toggle whether form errors are shown
    - toggle whether fields are required
    
    Add sample form errors.
    wesleyboar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7243312 View commit details
    Browse the repository at this point in the history
  15. fix(components): forms, select errors by query

    Select error lists by query, not class.
    
    So we can get `.field-errors` and `.form-errors`.
    wesleyboar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    956f927 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. feat: c-message scopes & complete a11y colors

    Notice: The c-message is not documented yet.
    wesleyboar committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    49a26a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5142a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70049dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8a10619 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Configuration menu
    Copy the full SHA
    b24663a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Configuration menu
    Copy the full SHA
    7f7545d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14cb14e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Configuration menu
    Copy the full SHA
    520014f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d1941c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96a159c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    87483dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    486d0b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    65d5b48 View commit details
    Browse the repository at this point in the history
  7. fix(c-form): do not require fish fields

    Multi-checkbox field cannot be required without Javascript. Also, Django CMS Forms does not require these.
    wesleyboar committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1001393 View commit details
    Browse the repository at this point in the history