Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(o-fixed-header-table): wrapper vs non-wrapper usage #83

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 6, 2022

Overview

Show that o-fixed-header-table can be used directly on table (or on wrapper).

Related

N/A

Changes

  • feat(elements): support table template class param (95021f1)
  • feat(elements): add table class param usage (602b8a0)
  • fix(o-fixed-header-table): better align examples (09557ec)
  • fix(o-fixed-header-table): terse bold wrap notice (634b2ed)
  • chore(o-fixed-header-table): don't abuse <dd>'s (9a36f9e)

Testing

  1. Open "O Fixed Table Header".
  2. Verify two tables appear.
  3. Verify both tables scroll.
  4. Verify header on each table stays in view when scrolling.
  5. Verify notes clarify that wrapper is not necessary, but just an in-case-you-need it option.

UI

scroll to top scroll to bottom
scroll to top scroll to bottom

@wesleyboar wesleyboar merged commit aa79afa into main Dec 6, 2022
@wesleyboar wesleyboar deleted the bugfix/o-fixed-header-table branch December 6, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant