Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form patterns bugs found via tup UI #91

Draft
wants to merge 110 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 14, 2022

Overview

Fix various Form pattern bugs (found in TACC/tup-ui).

Status

Related

Changes

Testing

UI

Also:
- add MuiTab use case to bootstrap.modal
- add MuiTab stylesheet for portal
- remove outdated icon trump files
- add base stylesheets for clients to load

Client should always load base.css first.

| stylesheet      | root¹ | cms² | portal³ | header ⁴ |
| -               |   -   |  -   |    -    |    -     |
| base.css        |   ✓   |  —   |    —    |    —     |
| base.cms.css    |   —   |  ✓   |    —    |    —     |
| base.portal.css |   —   |  —   |    ✓    |    —     |
| base.header.css |   —   |  —   |    —    |    ✓     |

There may be a base.docs.css after TUP-264.

¹ everything except cms, portal, and header
² e.g. cms
³ e.g. cepv2, tup-ui
⁴ e.g. cms, cepv2, frontera-tech-docs
| stylesheet | root¹ | cms² | portal³ | header ⁴ |
| - | - | - | - | - |
| core-styles.base.css | ✓ | — | — | — |
| core-styles.cms.css | — | ✓ | — | — |
| core-styles.portal.css | — | — | ✓ | — |
| core-styles.header.css | — | — | — | ✓ |

There may be a core-styles.docs.css after TUP-264.

¹ everything except cms, portal, and header
² e.g. cms
³ e.g. cepv2, tup-ui
⁴ e.g. cms, cepv2, frontera-tech-docs
With layers, core-styles.header.css must overwrite core-styles.cms.css.

Sans layers, site.header.css relied on bootstrap to override site.css.
Avoid dupllicate custom property (a.k.a. variable) definitions in:
- `.core-styles.cms.css`
- `.core-styles.header.css`
- some changes may be for main branch
- some changes may be for task/base-cms-portal-header branch

1. testing pattern for Core-CMS djangco.cms.forms
2. new c-form component & pattern needs template
3. just begining form.cms pattern
4. update s-affixed-input-… accordingly (for: 2, 3)
4. initial change of partials to use core-styles.*.css
- some changes may be for main branch
- some changes may be for task/base-cms-portal-header branch

1. testing pattern for Core-CMS djangco.cms.forms
2. new c-form component & pattern needs template
3. just begining form.cms pattern
4. update s-affixed-input-… accordingly (for: 2, 3)
4. initial change of partials to use core-styles.*.css
This is for CMS, but was being tested here. it works now.

Latest real bug was misssing the .html extension inthe demo.

This pattern was just committed in TACC/Core-CMS:
- task/get-core-styles-beyond-0.11.0
- d13ca50

I am porting the polishes and fixes here just so that when I delete I am deleting at the time at which CMS resumes control of it.
- build
- removed import of settings by src/_imports files
- added `core-styles.settings.css`
- changed demo to always load `core-styles.settings.css` up front

BREAKING CHANGE: Clients must include `settings.css` OR `base.css` e.g.
- @import url('@tacc/core-styles/dist/core-styles.settings.css')
- @import url('@tacc/core-styles/dist/core-styles.base.css')
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
This update fixes bug where layer() was not retained on @import rules!
This caused broken styles in CMS. The alpha solution was re-evaluated last week. It will be rolled back.
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
…l-header--bugfix/form-patterns-bugs-found-via-tup-ui
@wesleyboar wesleyboar added the paused Started but not actively in progress label Jan 8, 2024
@wesleyboar wesleyboar changed the title Bugfix/form patterns bugs found via tup UI fix: form patterns bugs found via tup UI Aug 30, 2024
@wesleyboar wesleyboar added fix Fixes user-facing behavior or feature patch A backward-compatible fix labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix paused Started but not actively in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant