Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnostic composed #110

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Agnostic composed #110

merged 9 commits into from
Aug 21, 2024

Conversation

olivierlabayle
Copy link
Member

@olivierlabayle olivierlabayle commented May 27, 2024

This PR is BREAKING.

This PR defines a new JointEstimand type that simply contains multiple one dimensional estimands. Such an estimand can be estimated as simply as any one dimensional estimand. Then using compose(f, jointestimand) any function can be evaluated and confidence regions provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here, if I'm following correctly will allow the user to access the original joint estimate (in case they want to make their own custom estimate in post) and composed estimate whos function is defined in the estimand creation process? Also what is the EICEestimate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment points to any aprticular piece of the code. An estimate is always associated with the estimand that it tries to estimate. EICEestimate is just a super type, stands for EfficientInfluenceCurveEstimate.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this would be an example of how to use the composed estimand once the joints are defined? Would the estimand file be populated with both joint and composed estimands?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, for an example look into composition.jl

Copy link

@joshua-slaughter joshua-slaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this update. I have left some comments for clarification on my end.

@olivierlabayle olivierlabayle merged commit 4fbd86a into main Aug 21, 2024
15 checks passed
@olivierlabayle olivierlabayle deleted the agnostic_composed branch August 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants