Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftl init go should disallow module names that aren't valid Go package names #1710

Closed
alecthomas opened this issue Jun 7, 2024 · 0 comments
Closed

ftl init go should disallow module names that aren't valid Go package names #1710

alecthomas opened this issue Jun 7, 2024 · 0 comments
Labels
good first issue Good for newcomers next Work that will be be picked up next

Comments

@alecthomas
Copy link
Collaborator

eg. ftl init go . map is invalid because map is a keyword
@github-actions github-actions bot added the triage Issue needs triaging label Jun 7, 2024
@ftl-robot ftl-robot mentioned this issue Jun 7, 2024
Open
@alecthomas alecthomas added good first issue Good for newcomers next Work that will be be picked up next and removed triage Issue needs triaging labels Jun 10, 2024
@michaelneale michaelneale mentioned this issue Jun 11, 2024
Merged
michaelneale added a commit that referenced this issue Jun 11, 2024
@michaelneale
feat: check that go module name is valid and not a keyword (#1728)
0a30f58 
Fix for: #1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers next Work that will be be picked up next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelneale @alecthomas