Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --watch to ftl schema get #1824

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: add --watch to ftl schema get #1824

merged 2 commits into from
Jun 18, 2024

Conversation

safeer
Copy link
Contributor

@safeer safeer commented Jun 18, 2024

Fixes #1626

@safeer safeer requested a review from wesbillman June 18, 2024 19:42
@safeer safeer requested a review from alecthomas as a code owner June 18, 2024 19:42
@safeer safeer requested review from a team and worstell and removed request for a team June 18, 2024 19:42
@ftl-robot ftl-robot mentioned this pull request Jun 18, 2024
Copy link
Member

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That was easy :)

if g.Watch {
fmt.Printf("missing modules: %v\n", missingNames)
} else {
return fmt.Errorf("missing modules: %v", missingNames)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably print this as a comma separate list for missingNames

@safeer safeer merged commit c668288 into main Jun 18, 2024
41 checks passed
@safeer safeer deleted the saf/watch-schema-get branch June 18, 2024 19:59
@worstell worstell added the approved Marks an already closed PR as approved label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a --watch flag to ftl schema get
3 participants