fix: ensure topic name matches idiomatic variable name #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
|
matt2e
reviewed
Jul 8, 2024
go-runtime/compile/schema.go
Outdated
| if t, ok := varDecl.Specs[0].(*ast.ValueSpec); ok { | ||
| varName := t.Names[0].Name | ||
| if expVarName := strcase.ToUpperCamel(name); varName != expVarName { | ||
| pctx.errors.add(errorf(node, "unexpected topic variable name %q, did you mean %q?", varName, expVarName)) |
matt2e
approved these changes
Jul 8, 2024
safeer
force-pushed
the
saf/topic-var-name-match
branch
from
b69adf0
to
8871202
Compare
worstell
approved these changes
Jul 9, 2024
|
@safeer is this one ready to merge or do you have more changes coming? |
@wesbillman this is a breaking change that requires clients to update their topic varnames |
safeer
force-pushed
the
saf/topic-var-name-match
branch
from
c8c38ae
to
ae7f5c5
Compare
|
Introduced a stripped upper camel case to remove the grossness in the generated code that was being forced upon the original source. See my convo with myself in #1919 😆 Still breaks client code; varname for a topic like |
safeer
force-pushed
the
saf/topic-var-name-match
branch
from
c965c39
to
994c600
Compare
|
Now prescriptive about topic names. Breaks client code, so not merging yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1919