feat: initial Java database work #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/java-databases
branch
from
35de186
to
25f26fa
Compare
alecthomas
reviewed
Aug 16, 2024
jvm-runtime/ftl-runtime/common/runtime/src/main/java/xyz/block/ftl/runtime/FTLController.java
Show resolved
Hide resolved
| public record Datasource(String connectionString, String username, String password) { | ||
|
|
||
| public static Datasource fromDSN(String dsn) { | ||
| //TODO: this is horrible, just quick hack for now |
There was a problem hiding this comment.
Lots of cleanup is needed, this was mostly about making sure that I could integrate everything the way I expected to. I should have a cleaned up version at some point on Monday.
stuartwdouglas
force-pushed
the
stuartwdouglas/java-databases
branch
2 times, most recently
from
ebd0ce3
to
87c85dd
Compare
stuartwdouglas
requested review from
jonathanj-square
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/java-databases
branch
from
87c85dd
to
0b8f526
Compare
|
This should be good to go now. |
alecthomas
approved these changes
Aug 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stuartwdouglas
force-pushed
the
stuartwdouglas/java-databases
branch
from
0b8f526
to
26cb7d2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fixes: 2392
stuartwdouglas
force-pushed
the
stuartwdouglas/java-databases
branch
from
26cb7d2
to
ae5dc05
Compare
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.