Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tanstack query #2406

Merged
merged 2 commits into from
Aug 16, 2024
Merged

feat: Add tanstack query #2406

merged 2 commits into from
Aug 16, 2024

Conversation

wesbillman
Copy link
Member

Fixes #2403

@wesbillman wesbillman requested review from alecthomas and a team as code owners August 16, 2024 19:23
@wesbillman wesbillman requested review from safeer and deniseli and removed request for a team August 16, 2024 19:23
@github-actions github-actions bot changed the title Add tanstack query feat: Add tanstack query Aug 16, 2024
@ftl-robot ftl-robot mentioned this pull request Aug 16, 2024
Open
@wesbillman wesbillman added the run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue label Aug 16, 2024
alecthomas
alecthomas approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much React magic STAMP

@wesbillman
Copy link
Member Author

Haha yeah! This mostly just moves the backend request stuff to a dedicated api folder with use* with caching. So any component anywhere can ask for data from the backend and this caching system will only request things if it's new 🤞

@wesbillman wesbillman added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 147a1f2 Aug 16, 2024
17 checks passed
@wesbillman wesbillman deleted the add-tanstack-query branch August 16, 2024 21:57
safeer pushed a commit that referenced this pull request Aug 19, 2024
@wesbillman @safeer
feat: Add tanstack query (#2406)
ea0794d 
Fixes #2403
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@safeer safeer Awaiting requested review from safeer safeer is a code owner automatically assigned from TBD54566975/ftl-reviewers

@deniseli deniseli Awaiting requested review from deniseli

Assignees
No one assigned
Labels
run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Tanstack Query for requests and caching
2 participants
@wesbillman @alecthomas