Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console verb page loading #2434

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: console verb page loading #2434

merged 1 commit into from
Aug 20, 2024

Conversation

wesbillman
Copy link
Member

Less broke now! 😂

I think with streaming queries, isLoading will always be true with tanstack since it's like streaming yo.

Screenshot 2024-08-19 at 5 22 22 PM

@wesbillman wesbillman requested review from alecthomas and a team as code owners August 20, 2024 00:23
@wesbillman wesbillman requested review from matt2e and removed request for a team August 20, 2024 00:23
@ftl-robot ftl-robot mentioned this pull request Aug 20, 2024
Open
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 20, 2024
deniseli
deniseli approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@deniseli deniseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

Merged via the queue into main with commit 2de00c5 Aug 20, 2024
19 checks passed
@stuartwdouglas stuartwdouglas deleted the fix-console-verbpage-loading branch August 20, 2024 00:32
@matt2e matt2e added the approved Marks an already closed PR as approved label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@deniseli deniseli deniseli approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas

@matt2e matt2e Awaiting requested review from matt2e matt2e was automatically assigned from TBD54566975/ftl-reviewers

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wesbillman @stuartwdouglas @deniseli @matt2e