Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up codemirror panel resizing #2472

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: clean up codemirror panel resizing #2472

merged 2 commits into from
Aug 21, 2024

Conversation

deniseli
Copy link
Contributor

Issue: #2458

Changes:

  • Response panel is only displayed when Body tab (i.e. Request tab) is selected, instead of taking screen real estate away from the read-only schema tabs
  • Border between request and response panels is replaced with a full-width draggable handle
    • Related: fixed the existing bugs in components/ResizeableVerticalPanels.tsx
  • All codemirror components automatically take the full height of their container
Screen.Recording.2024-08-21.at.2.06.40.PM.mov

@ftl-robot ftl-robot mentioned this pull request Aug 21, 2024
Open
@deniseli
smooth resizing of panels
9c97905 
editor height

cleanup
@deniseli deniseli marked this pull request as ready for review August 21, 2024 18:17
@deniseli deniseli requested review from alecthomas and a team as code owners August 21, 2024 18:17
@deniseli deniseli requested review from wesbillman and removed request for a team August 21, 2024 18:17
@wesbillman
Copy link
Member

Nice! This is much better! 🥳

@wesbillman wesbillman added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 02b5eeb Aug 21, 2024
19 checks passed
@wesbillman wesbillman deleted the dli/editor-panels branch August 21, 2024 18:47
@deniseli deniseli mentioned this pull request Aug 21, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deniseli @wesbillman