Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change JVM API for pubsub #3549

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: change JVM API for pubsub #3549

wants to merge 3 commits into from
+320 −282

Conversation

stuartwdouglas
Copy link
Collaborator

@stuartwdouglas stuartwdouglas commented Nov 27, 2024 •
edited
Loading

The main changes are:

  • No generated annotations, instead ConsumeableTopic classes will be generated
  • Subscriptions for local and remote topics look the same
  • This results in a more consistent and user friendly API

This was referenced Nov 27, 2024
Open
Open
Open
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/jvm-api branch 3 times, most recently from 5163085 to 17f27b0 Compare November 27, 2024 22:38
@stuartwdouglas stuartwdouglas marked this pull request as ready for review November 27, 2024 22:38
@stuartwdouglas stuartwdouglas requested review from worstell and removed request for a team November 27, 2024 22:38
@stuartwdouglas stuartwdouglas changed the title wip: New JVM API for pubsub feat: change JVM API for pubsub Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@worstell worstell Awaiting requested review from worstell worstell is a code owner automatically assigned from TBD54566975/ftl-jvm-team

@matt2e matt2e Awaiting requested review from matt2e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stuartwdouglas