Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exchange.BuildPresentationSubmission to have a slightly different interface #165

Closed
nitro-neal opened this issue Aug 10, 2022 · 1 comment
Assignees
Milestone

Comments

@nitro-neal
Copy link
Contributor

Have the presentation claim's token format support signedVCBytes for the BuildPresentationSubmission function

currently:

testOutput, err := signing.ParseVerifiableCredentialFromJWT(string(signedVCBytes))
testOutputBytes, _ := json.Marshal(testOutput)

presentationClaim := exchange.PresentationClaim{
	Token:                         util.StringPtr(string(testOutputBytes)),
	JWTFormat:                     exchange.JWTVC.Ptr(),
	SignatureAlgorithmOrProofType: string(crypto.EdDSA),
}

presentationSubmissionBytes, err := exchange.BuildPresentationSubmission(holderSigner, *presentationDefinition, []exchange.PresentationClaim{presentationClaim}, exchange.JWTVPTarget)

we need the nested BuildPresentationSubmission function to handle raw signedVCBytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants