Presentation Exchange: support for json schema filtering and relational constraints #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 57.31% 57.38% +0.07%
==========================================
Files 51 51
Lines 6339 6410 +71
==========================================
+ Hits 3633 3678 +45
- Misses 2017 2032 +15
- Partials 689 700 +11
|
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
decentralgabe
commented
Apr 13, 2023
| // CredentialsFromInterface turn a generic cred into a known shape without maintaining the proof/signature wrapper | ||
| func CredentialsFromInterface(genericCred any) (*credential.VerifiableCredential, error) { | ||
| // ToCredential turn a generic cred into its known object model | ||
| func ToCredential(genericCred any) (*credential.VerifiableCredential, error) { |
There was a problem hiding this comment.
@nitro-neal refactored this method and the one below to handle jwt/json properly to fix #165
nitro-neal
reviewed
Apr 13, 2023
| // CredentialsFromInterface turn a generic cred into a known shape without maintaining the proof/signature wrapper | ||
| func CredentialsFromInterface(genericCred any) (*credential.VerifiableCredential, error) { | ||
| // ToCredential turn a generic cred into its known object model | ||
| func ToCredential(genericCred any) (*credential.VerifiableCredential, error) { |
There was a problem hiding this comment.
This is awesome, almost need this as a standard for every object.
nitro-neal
approved these changes
Apr 13, 2023
| func ClaimAsJSON(claim any) (map[string]any, error) { | ||
| switch c := claim.(type) { | ||
| // ToCredentialJSONMap turn a generic cred into a JSON object | ||
| func ToCredentialJSONMap(genericCred any) (map[string]any, error) { |
There was a problem hiding this comment.
Alternativly we could make this private and then the master ToCredential funciton will have the signature:
func ToCredential(genericCred any) (*credential.VerifiableCredential, map[string]any, jwt.Token, error) {
One func to rule them all
There was a problem hiding this comment.
I had it like this at first but figured it was cleaner to have each func do a single thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #350, #165, and partially #64