Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-ld cached doc loader #102

Conversation

singyiu
Copy link
Contributor

@singyiu singyiu commented Jun 13, 2022

json-gold does have the caching document loader implemented (RFC7324)
It is enabled by passing the caching loader into the ldProcessor options
Added it as the default option here.

Json-ld context can be loaded as a json-ld document (type map[string]interface{}) using the loadDocument function test example
or further converting it into a json-gold.Context object test example
A helper function "GetContextFromMap" was added.

util/helpers_test.go Outdated Show resolved Hide resolved
util/helpers_test.go Outdated Show resolved Hide resolved
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this! very nice
will let you revise if you wish and merge if you wish

@singyiu
Copy link
Contributor Author

singyiu commented Jun 14, 2022

@decentralgabe
Thanks a lot for the review.
Updated the nit.
I don't have the permission to merge as a first time contributors of this project though.
Will leave that to you.

@decentralgabe decentralgabe merged commit 8ab6396 into TBD54566975:main Jun 14, 2022
@decentralgabe
Copy link
Member

Thanks @singyiu appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants