-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verifiable credential example #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andorsk
before moving your examples, let's agree on whether they should be tests or as is.
the main benefit of tests:
- not included in the binary when you're using the sdk as a dependency
- simple to run independently
- can easily determine if the examples break, as tests are run for a CI-precondition
- simpler error handling with assertions
benefits of main.go:
- easier to see "real world" usage
what do you think?
Me personally, I've suggested we follow precedence and standards, which is that these are not tests (b/c they aren't) and run as example files. There are more reasons I can give, but ultimately I don't think we are facing a unique problem here. It seems to me, how things have been done historically seems like a reasonable way to handle it. See here for some examples of examples 😆 : That being said: I'd suggest three lines here of action, which would result in a conclusion:
What's the most important here is we have some examples available for everyone else. We can always change things later if we realize we made a mistake here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andorsk I appreciate the links, I wasn't aware this was a convention.
I'm OK to merge as-is. In the future, we can consider creating a new repo ssi-sdk-examples
and moving them there; however for now this is an excellent start.
I noticed other examples rely on handleError
, perhaps worth creating an examples util file or something similar.
Thanks @decentralgabe for merging this in. And yep! I think that's totally fair. In fact, maybe we should see about putting all the examples in the same directory. Rather than different ones. Lots of work to do on the examples! I'm happy to chat about scope for improving them. |
please merge #126 first then this will follow: