Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presentation example #129

Merged
merged 7 commits into from
Jul 13, 2022
Merged

presentation example #129

merged 7 commits into from
Jul 13, 2022

Conversation

andorsk
Copy link
Contributor

@andorsk andorsk commented Jul 4, 2022

Added presentation example. Please merge #126 before merging this.

@andorsk andorsk mentioned this pull request Jul 4, 2022
Closed
@decentralgabe
Copy link
Member

perhaps can handle the de-duplication of handleError in this one?

@andorsk
Copy link
Contributor Author

andorsk commented Jul 7, 2022

all good comments. thanks @decentralgabe! I'll see about getting to them on Friday. Have some other items to focus on today.

@andorsk
Copy link
Contributor Author

andorsk commented Jul 8, 2022

Moving this to sometime early next week. Ran out of time. Thanks.

@andorsk
Copy link
Contributor Author

andorsk commented Jul 13, 2022

perhaps can handle the de-duplication of handleError in this one?

I think for this one, we should refactor all the examples into a single package ( in a new PR ) , and then we can have some shared functions.

@andorsk andorsk marked this pull request as ready for review July 13, 2022 15:23
@andorsk
Copy link
Contributor Author

andorsk commented Jul 13, 2022

Referenced here: #144

@decentralgabe decentralgabe merged commit 61ceb89 into TBD54566975:main Jul 13, 2022
decentralgabe added a commit that referenced this pull request Jul 13, 2022
@decentralgabe
Merge remote-tracking branch 'origin/main' into pe-builders
ad21f7d 
* origin/main:
  Update CONTRIBUTING.md (#145)
  presentation example (#129)
  examples/did: Fix typo (#143)

# Conflicts:
#	example/presentation/presentation.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decentralgabe decentralgabe decentralgabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andorsk @decentralgabe