Adding new function that converts a ed25519 key to JWK #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested changes
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 53.32% 53.42% +0.09%
==========================================
Files 32 32
Lines 3773 3785 +12
==========================================
+ Hits 2012 2022 +10
- Misses 1389 1391 +2
Partials 372 372
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cryptosuite/jsonwebkey2020.go
Outdated
|
|
||
| // DeriveJSONWebKey2020FromRSA returns a JsonWebKey2020 value, containing both public and private keys | ||
| // for an RSA-2048 key. This function coverts a rsa.PrivateKey to a JsonWebKey2020 | ||
| func DeriveJSONWebKey2020FromRSA(privKey rsa.PrivateKey) (*JSONWebKey2020, error) { |
There was a problem hiding this comment.
nit: is the Derive prefix useful? What about just JSONWebKey2020From...?
decentralgabe
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function coverts a ed25519.PrivateKey to a JsonWebKey2020
This pr is for this issue - #160