-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new function that converts a ed25519 key to JWK #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - can you add the same method for each of the key gen functions?
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 53.32% 53.42% +0.09%
==========================================
Files 32 32
Lines 3773 3785 +12
==========================================
+ Hits 2012 2022 +10
- Misses 1389 1391 +2
Partials 372 372
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cryptosuite/jsonwebkey2020.go
Outdated
|
||
// DeriveJSONWebKey2020FromRSA returns a JsonWebKey2020 value, containing both public and private keys | ||
// for an RSA-2048 key. This function coverts a rsa.PrivateKey to a JsonWebKey2020 | ||
func DeriveJSONWebKey2020FromRSA(privKey rsa.PrivateKey) (*JSONWebKey2020, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is the Derive
prefix useful? What about just JSONWebKey2020From...
?
This new function coverts a ed25519.PrivateKey to a JsonWebKey2020
This pr is for this issue - #160