Implement did-pkh #168
Merged
Implement did-pkh #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
decentralgabe
requested changes
Aug 18, 2022
did/model.go
Outdated
| @@ -95,6 +95,8 @@ type VerificationMethod struct { | |||
| PublicKeyJWK *cryptosuite.PublicKeyJWK `json:"publicKeyJwk,omitempty" validate:"omitempty,dive"` | |||
| // https://datatracker.ietf.org/doc/html/draft-multiformats-multibase-03 | |||
| PublicKeyMultibase string `json:"publicKeyMultibase,omitempty"` | |||
| // for PKH DIDs - https://github.com/w3c-ccg/did-pkh/blob/90b28ad3c18d63822a8aab3c752302aa64fc9382/did-pkh-method-draft.md | |||
| BlockchainAccountId string `json:"blockchainAccountId,omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| BlockchainAccountId string `json:"blockchainAccountId,omitempty"` | |
| BlockchainAccountID string `json:"blockchainAccountId,omitempty"` |
did/pkh.go
Outdated
Comment on lines
90
to
94
| var knownDIDPKHContextJson interface{} | ||
| err = json.Unmarshal([]byte(knownDIDPKHContext), &knownDIDPKHContextJson) | ||
| if err != nil { | ||
| return nil, util.LoggingErrorMsg(err, "could not unmarshal known context json") | ||
| } |
There was a problem hiding this comment.
Suggested change
| var knownDIDPKHContextJson interface{} | |
| err = json.Unmarshal([]byte(knownDIDPKHContext), &knownDIDPKHContextJson) | |
| if err != nil { | |
| return nil, util.LoggingErrorMsg(err, "could not unmarshal known context json") | |
| } | |
| var knownDIDPKHContextJSON interface{} | |
| if err := json.Unmarshal([]byte(knownDIDPKHContext), &knownDIDPKHContextJSON); err != nil { | |
| return nil, util.LoggingErrorMsg(err, "could not unmarshal known context json") | |
| } |
did/pkh.go
Outdated
| } | ||
|
|
||
| return &DIDDocument{ | ||
| Context: knownDIDPKHContextJson, |
There was a problem hiding this comment.
Suggested change
| Context: knownDIDPKHContextJson, | |
| Context: knownDIDPKHContextJSON, |
did/pkh.go
Outdated
| } | ||
|
|
||
| func GetSupportedNetworks() []Network { | ||
| networks := []Network{} |
There was a problem hiding this comment.
nit: favor var initialization
var networks []Network
decentralgabe
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements they did-pkh method as specified here - https://github.com/w3c-ccg/did-pkh/blob/90b28ad3c18d63822a8aab3c752302aa64fc9382/did-pkh-method-draft.md
Linked issue here - #33
This change includes construction of a Bitcoin, Ethereum, or Polygon did:pkh from a network and an address. For more granular creation it can be constructed from a namespace, reference, and account address.
// Example Reference: did:pkh:namespace:reference:account_address
// Ethereum: did:pkh:eip155:1:0xb9c5714089478a327f09197987f16f9e5d936e8a