-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DID pkg test coverage #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 54.82% 57.17% +2.34%
==========================================
Files 31 31
Lines 3732 3740 +8
==========================================
+ Hits 2046 2138 +92
+ Misses 1310 1242 -68
+ Partials 376 360 -16
|
actually found a few issues! |
did/key.go
Outdated
@@ -31,6 +31,23 @@ const ( | |||
DIDKeyPrefix = "did:key" | |||
) | |||
|
|||
func (d DIDKey) IsValid() bool { | |||
return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no checks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, whoops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look great!
Increasing test coverage. Minor refactors.