Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple JWT and LD signing/verifying paths #195

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

decentralgabe
Copy link
Member

fixes #194

Notably, this makes all endpoints use JWTs, leaving LD suites to be a bit lonely. LD suite support is possible but not integrated. Still thinking of the best way to include this...

@codecov-commenter
Copy link

Codecov Report

Merging #195 (d384d51) into main (3ced400) will increase coverage by 2.42%.
The diff coverage is 56.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   54.82%   57.25%   +2.42%     
==========================================
  Files          31       32       +1     
  Lines        3732     3726       -6     
==========================================
+ Hits         2046     2133      +87     
+ Misses       1310     1236      -74     
+ Partials      376      357      -19     
Impacted Files Coverage Δ
crypto/jwk.go 0.00% <0.00%> (ø)
did/model.go 100.00% <ø> (+44.12%) ⬆️
crypto/jwt.go 36.75% <36.75%> (ø)
did/pkh.go 77.00% <56.00%> (+2.56%) ⬆️
credential/exchange/request.go 36.92% <62.50%> (+4.46%) ⬆️
did/web.go 78.90% <68.97%> (+19.10%) ⬆️
did/util.go 53.39% <78.57%> (+15.89%) ⬆️
did/key.go 67.27% <81.82%> (+18.91%) ⬆️
credential/signing/jwt.go 32.92% <83.33%> (ø)
cryptosuite/jsonwebkey2020.go 61.87% <90.00%> (+4.93%) ⬆️
... and 11 more

@decentralgabe
Copy link
Member Author

Added #196 to address

crypto/jwt.go Outdated Show resolved Hide resolved
crypto/jwt.go Outdated Show resolved Hide resolved
Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@decentralgabe decentralgabe merged commit e2c3363 into main Sep 16, 2022
@decentralgabe decentralgabe deleted the sip-3-adjust-jwt-singing-in-the-sdk-ose-104 branch September 16, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT implementation is tightly coupled to the Linked Data Suite Implementation
3 participants