Construct JWKs generically from public and private keys #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 57.25% 57.81% +0.57%
==========================================
Files 32 32
Lines 3726 3840 +114
==========================================
+ Hits 2133 2220 +87
- Misses 1236 1252 +16
- Partials 357 368 +11
|
nitro-neal
approved these changes
Sep 20, 2022
| } | ||
|
|
||
| // PrivateKeyToPrivateKeyJWK converts a private key to a PrivateKeyJWK | ||
| func PrivateKeyToPrivateKeyJWK(key crypto.PrivateKey) (*PublicKeyJWK, *PrivateKeyJWK, error) { |
There was a problem hiding this comment.
nit:
Have you thought about making the JWKFromRSAPrivateKey functions private? It will be a lot less functions for a user to deal with and just have the global function available to them
There was a problem hiding this comment.
yeah, let me change this. can always make them public later if needed
decentralgabe
deleted the
construct-jwks-generically-from-private-ose-110
branch
|
@decentralgabe just used this today. Thanks. really helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq for TBD54566975/ssi-service#105
Mostly shuffling things around to further decouple data integrity suites from JWKs.