Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconstruct priv key better #211

Merged
merged 1 commit into from
Oct 1, 2022
Merged

reconstruct priv key better #211

merged 1 commit into from
Oct 1, 2022

Conversation

decentralgabe
Copy link
Member

the key type was not maintained, leading to signing errors

@codecov-commenter
Copy link

Codecov Report

Merging #211 (c3d5e9c) into main (56fc273) will increase coverage by 0.23%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   58.04%   58.27%   +0.23%     
==========================================
  Files          33       33              
  Lines        3813     3841      +28     
==========================================
+ Hits         2213     2238      +25     
- Misses       1229     1232       +3     
  Partials      371      371              
Impacted Files Coverage Δ
crypto/jwt.go 39.32% <0.00%> (ø)
crypto/keys.go 83.51% <91.43%> (+1.01%) ⬆️
crypto/models.go 11.11% <100.00%> (ø)
cryptosuite/jsonwebkey2020.go 50.38% <100.00%> (ø)
did/key.go 67.27% <100.00%> (ø)
did/model.go 100.00% <100.00%> (ø)
did/util.go 53.39% <100.00%> (ø)

@decentralgabe decentralgabe merged commit ec86410 into main Oct 1, 2022
@decentralgabe decentralgabe deleted the fix-priv-key-to-bytes branch October 1, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants