-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign and Verify JSONWebSignature2020 Suite #22
Conversation
assert.NoError(t, err) | ||
} | ||
|
||
// https://github.com/decentralized-identity/JWS-Test-Suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistermoe this is the test suite I could not get to verify. I'd appreciate if you could take a look through my implementation of the data integrity suite as a sanity check.
// assert.NoError(t, err) | ||
// | ||
// // verify known credential | ||
// err = suite.Verify(verifier, &knownCredSigned) | ||
// assert.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything will pass in this test except the last assertion - which is where I validate the transmute implementation's cred against our verification method
As far as I can tell, this implements the JsonWebSignature2020 suite. I've annotated the code with relevant portions of the algorithms described in the data integrity specification. I spent a long time trying to verify credential data signed by other implementations in the DIF Test Suite to no avail. I am not even sure the implementations in that suite are able to verify data created by other implementations.
Pending glaring errors or breakthroughs I'd prefer to merge this as-is and handle clean-up and test suite compliance in follow up tasks, some of which I've already created #23 #21