Sign and Verify JSONWebSignature2020 Suite #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
commented
Feb 25, 2022
| assert.NoError(t, err) | ||
| } | ||
|
|
||
| // https://github.com/decentralized-identity/JWS-Test-Suite |
There was a problem hiding this comment.
@mistermoe this is the test suite I could not get to verify. I'd appreciate if you could take a look through my implementation of the data integrity suite as a sanity check.
decentralgabe
commented
Feb 25, 2022
| // assert.NoError(t, err) | ||
| // | ||
| // // verify known credential | ||
| // err = suite.Verify(verifier, &knownCredSigned) | ||
| // assert.NoError(t, err) |
There was a problem hiding this comment.
everything will pass in this test except the last assertion - which is where I validate the transmute implementation's cred against our verification method
This was referenced Feb 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this implements the JsonWebSignature2020 suite. I've annotated the code with relevant portions of the algorithms described in the data integrity specification. I spent a long time trying to verify credential data signed by other implementations in the DIF Test Suite to no avail. I am not even sure the implementations in that suite are able to verify data created by other implementations.
Pending glaring errors or breakthroughs I'd prefer to merge this as-is and handle clean-up and test suite compliance in follow up tasks, some of which I've already created #23 #21