LD Key utilities #220
Merged
LD Key utilities #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
reviewed
Oct 7, 2022
| @@ -32,6 +32,10 @@ const ( | |||
| PS256 SignatureAlgorithm = "PS256" | |||
| ) | |||
|
|
|||
| func (kt KeyType) String() string { | |||
There was a problem hiding this comment.
I'm more used to .ToString() (java brain here) but if this is the better Go convention we can stick with this
There was a problem hiding this comment.
nitro-neal
reviewed
Oct 7, 2022
| default: | ||
| return nil, fmt.Errorf("unsupported key type: %s", kt) | ||
| } | ||
| return crypto.BytesToPubKey(keyBytes, convertedKeyType) |
There was a problem hiding this comment.
type {
keyBytes []byte
keyType kt.String() type
}
would a wrapper object give much value? I guess you already have the keytype in hand so maybe not
There was a problem hiding this comment.
hmm...yeah we have LDKeyType and this is going to KeyType, but the interface that this method is most often being used with is expecting a gocrypto.PublicKey
nitro-neal
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.