Cred Manifest <--> Cred Application Validation #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
commented
Oct 10, 2022
credential/manifest/model.go
Outdated
| } | ||
| } | ||
|
|
||
| // TODO: Path validation |
There was a problem hiding this comment.
There was a problem hiding this comment.
perhaps make sure the path exists?
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 57.76% 57.83% +0.08%
==========================================
Files 36 36
Lines 3996 4053 +57
==========================================
+ Hits 2308 2344 +36
- Misses 1304 1320 +16
- Partials 384 389 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsValidPair validates the rules on how a credential manifest [cm] and credential application [ca] relate to each other https://identity.foundation/credential-manifest/#credential-application
The object MUST contain a manifest_id property. The value of this property MUST be the id of a valid Credential Manifest.
The following rules are enforced in the pr:
The ca must have a format property if the related Credential Manifest specifies a format property.
Its value must be a subset of the format property in the Credential Manifest that this Credential Submission
The Credential Application object MUST contain a presentation_submission property IF the related Credential Manifest contains a presentation_definition.
Its value MUST be a valid Presentation Submission:
https://identity.foundation/presentation-exchange/#presentation-submission
The presentation_submission object MUST contain a definition_id property. The value of this property MUST be the id value of a valid Presentation Definition.
The descriptor_map object MUST include a format property. The value of this property MUST be a string that matches one of the Claim Format Designation. This denotes the data format of the Claim.