schema and pkh refactor #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
decentralgabe
commented
Oct 11, 2022
decentralgabe
commented
- update credential manifest schema from remove uri json schema constraint decentralized-identity/credential-manifest#122
- minor pkh refactor
- moved out non-schemas from schema dir
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 57.83% 58.21% +0.38%
==========================================
Files 36 36
Lines 4053 4085 +32
==========================================
+ Hits 2344 2378 +34
+ Misses 1320 1319 -1
+ Partials 389 388 -1
|
nitro-neal
reviewed
Oct 12, 2022
did/pkh.go
Outdated
| EcdsaSecp256k1RecoveryMethod2020 = "EcdsaSecp256k1RecoveryMethod2020" | ||
| ) | ||
|
|
||
| // GetDIDPKHContext returns a context which should be manually inserted into each did:pkh document. This will likely |
There was a problem hiding this comment.
two spaces between context and which
nitro-neal
reviewed
Oct 12, 2022
| } | ||
|
|
||
| // GetVerificationTypeForNetwork returns the verification key type for a given network | ||
| func GetVerificationTypeForNetwork(n Network) (string, error) { |
There was a problem hiding this comment.
Nice, we don't have to have a mapping anymore, there could be a case where we add a new pkh but forget to add it here in the GetVerificationTypeForNetwork function, thats why I opt to have one source of truth mapping. But this works good too
There was a problem hiding this comment.
good point, let me see how to define this once
nitro-neal
reviewed
Oct 12, 2022
dwn/model.go
Outdated
| return nil | ||
| // IsValidDWNMessage validates a given dwn message object against its known JSON schema | ||
| func IsValidDWNMessage(msg DWNMessage) error { | ||
| // TODO: add a schema when there is one |
There was a problem hiding this comment.
forget to remove comment?
There was a problem hiding this comment.
changing this to link to #62 to re-add schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.