adding vc validation to IsValidCredentialApplicationForManifest function #230
Conversation
credential/manifest/model.go
Outdated
| @@ -144,8 +145,9 @@ func (cf *CredentialResponse) IsValid() error { | |||
| } | |||
|
|
|||
| // IsValidCredentialApplicationForManifest validates the rules on how a credential manifest [cm] and credential application [ca] relate to each other https://identity.foundation/credential-manifest/#credential-application | |||
| func IsValidCredentialApplicationForManifest(cm CredentialManifest, ca CredentialApplication) error { | |||
| func IsValidCredentialApplicationForManifest(cm CredentialManifest, ca CredentialApplication, vcs []credential.VerifiableCredential) error { | |||
There was a problem hiding this comment.
nit: consider making this a variadic argument so it can be an optional parameter
IsValidCredentialApplicationForManifest(cm CredentialManifest, ca CredentialApplication, vcs ...credential.VerifiableCredential)
There was a problem hiding this comment.
Hmm, so if there is no vcs then would it be expected that the application's presentation_submission's descriptor_map be empty?
There was a problem hiding this comment.
t.Run("only ca cm validation, no vcs", func(tt *testing.T) {
cm, ca, _ := getValidTestCmCaVc(tt)
cm.PresentationDefinition.InputDescriptors = make([]exchange.InputDescriptor, 0)
ca.PresentationSubmission.DescriptorMap = make([]exchange.SubmissionDescriptor, 0)
err := IsValidCredentialApplicationForManifest(cm, ca)
assert.NoError(tt, err)
})
Trying to get the above to work , but getting error - presentation definition must have at least one input descriptor
what would the input descriptor look like if there are no vcs? Can this case exist and be a valid ca,cm?
There was a problem hiding this comment.
if there are input descriptors there must be VCs, so if there's a presentation definition at all - there must be VCs
There was a problem hiding this comment.
ok good stuff, I was trying to make a presentation definition with 0 input descriptors,
but yup this works now with just an empty presentation definition
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 58.03% 58.10% +0.07%
==========================================
Files 35 35
Lines 4060 4115 +55
==========================================
+ Hits 2356 2391 +35
- Misses 1317 1330 +13
- Partials 387 394 +7
|
Co-authored-by: Gabe <gcohen@squareup.com>
adding vc validation to IsValidCredentialApplicationForManifest function