added better test code coverage for did peer #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decentralgabe sorry for taking so long on this. Just haven't had a lot of cycles to spare lately. I'll see about adding even more tests in a future PR. For now, this should help a little with code coverage re: did peer |
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 58.10% 59.23% +1.13%
==========================================
Files 35 35
Lines 4143 4155 +12
==========================================
+ Hits 2407 2461 +54
+ Misses 1333 1296 -37
+ Partials 403 398 -5
|
decentralgabe
requested changes
Oct 19, 2022
|
thanks for taking the time to add these @andorsk ! |
| d, ok := did.(DIDPeer) | ||
| if !ok { | ||
| return nil, errors.Wrap(util.CastingError, "did:peer") | ||
| } | ||
|
|
||
| // The '=' at the end is an artifact of the encoding, and will mess up the decoding |
There was a problem hiding this comment.
did you mean to comment this out?
decentralgabe
approved these changes
Oct 19, 2022
|
@andorsk this didn't get merged into main, did it? did you intend to close it |
|
oh. sorry. my mistake. misread the merge as it was going into main. I'll reopen it. Thanks. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding more test coverage to did peer. #209