Support returning failed input descriptors on cred application validation #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
reviewed
Oct 26, 2022
credential/manifest/model.go
Outdated
| // The Credential Application object MUST contain a presentation_submission property IF the related Credential | ||
| // Manifest contains a presentation_definition. Its value MUST be a valid Presentation Submission: | ||
| if cm.PresentationDefinition.IsEmpty() { | ||
| return |
There was a problem hiding this comment.
good call,
I wonder if there is an edge case where if there is not a PresDef but the presentation submission exists (for some reason?) and then it is invalid
There was a problem hiding this comment.
great point - will add a check
nitro-neal
reviewed
Oct 26, 2022
error/response.go
Outdated
| @@ -11,7 +11,7 @@ type ( | |||
| ) | |||
|
|
|||
| const ( | |||
| ApplicationError Type = "ApplicationError" | |||
| ApplicationError Type = "Valid" | |||
There was a problem hiding this comment.
do you want to rename ApplicationError to ValidError?
There was a problem hiding this comment.
whoops, will revert
nitro-neal
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.