-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support returning failed input descriptors on cred application validation #244
Conversation
credential/manifest/model.go
Outdated
// The Credential Application object MUST contain a presentation_submission property IF the related Credential | ||
// Manifest contains a presentation_definition. Its value MUST be a valid Presentation Submission: | ||
if cm.PresentationDefinition.IsEmpty() { | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call,
I wonder if there is an edge case where if there is not a PresDef but the presentation submission exists (for some reason?) and then it is invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point - will add a check
error/response.go
Outdated
@@ -11,7 +11,7 @@ type ( | |||
) | |||
|
|||
const ( | |||
ApplicationError Type = "ApplicationError" | |||
ApplicationError Type = "Valid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to rename ApplicationError to ValidError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, will revert
No description provided.