-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable golangci-lint #246
Enable golangci-lint #246
Conversation
var okp = cryptosuite.KTY("OKP") | ||
var ed25519 = cryptosuite.CRV("Ed25519") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I think we already have these types defined. cryptosuite.OKP
and cryptosuite.Ed25519
should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small ones - thanks for adding this!
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 59.56% 59.38% -0.18%
==========================================
Files 38 38
Lines 4273 4276 +3
==========================================
- Hits 2545 2539 -6
- Misses 1329 1335 +6
- Partials 399 402 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This PR includes:
lint
anddeps
targets.lint
will run golangci-lint with the commited configuration. I disabled a number of checks for revive, and updated the source code so that they all passed.deps
will installgolangci-lint
using homebrew.golangci-lint
action according to the instructions