Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golangci-lint #246

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

andresuribe87
Copy link
Contributor

This PR includes:

  • Adding mage lint and deps targets.
    • lint will run golangci-lint with the commited configuration. I disabled a number of checks for revive, and updated the source code so that they all passed.
    • deps will install golangci-lint using homebrew.
  • Added the golangci-lint action according to the instructions

crypto/jwk_test.go Outdated Show resolved Hide resolved
Comment on lines 61 to 62
var okp = cryptosuite.KTY("OKP")
var ed25519 = cryptosuite.CRV("Ed25519")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I think we already have these types defined. cryptosuite.OKP and cryptosuite.Ed25519 should work

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small ones - thanks for adding this!

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #246 (12dc352) into main (39fefd7) will decrease coverage by 0.18%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   59.56%   59.38%   -0.18%     
==========================================
  Files          38       38              
  Lines        4273     4276       +3     
==========================================
- Hits         2545     2539       -6     
- Misses       1329     1335       +6     
- Partials      399      402       +3     
Impacted Files Coverage Δ
credential/signing/jwt.go 31.33% <ø> (+0.19%) ⬆️
credential/verification/verification.go 100.00% <ø> (ø)
did/util.go 50.00% <0.00%> (ø)
error/response.go 100.00% <ø> (ø)
did/web.go 68.42% <25.00%> (-5.59%) ⬇️
cryptosuite/jsonwebkey2020.go 44.67% <33.33%> (ø)
credential/manifest/validation.go 63.82% <56.52%> (+0.48%) ⬆️
credential/verification/verifiers.go 60.00% <60.00%> (ø)
did/pkh.go 73.10% <66.67%> (ø)
did/peer.go 65.37% <68.42%> (-0.65%) ⬇️
... and 9 more

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@andresuribe87 andresuribe87 merged commit c1d4b23 into TBD54566975:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants