-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Presentation Exchange v2 and Latest CM #248
Conversation
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 59.39% 59.37% -0.03%
==========================================
Files 38 38
Lines 4280 4292 +12
==========================================
+ Hits 2542 2548 +6
- Misses 1336 1340 +4
- Partials 402 404 +2
|
err = builder.SetDescription("description") | ||
assert.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this test verify that the correct values are set when the CM is built?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
@@ -28,7 +28,7 @@ | |||
"$ref": "#/definitions/descriptor" | |||
}, | |||
"format": { | |||
"$ref": "https://identity.foundation/claim-format-registry/schemas/presentation-submission-claim-format-designations.json#/definitions/format" | |||
"$ref": "http://identity.foundation/claim-format-registry/schemas/presentation-submission-claim-format-designations.json#/definitions/format" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we not use https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json schema breaks when you do 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lit:
No description provided.