Fix jwk usage #249
Merged
Fix jwk usage #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 59.37% 58.85% -0.52%
==========================================
Files 38 38
Lines 4292 4437 +145
==========================================
+ Hits 2548 2611 +63
- Misses 1340 1414 +74
- Partials 404 412 +8
|
nitro-neal
approved these changes
Nov 7, 2022
Co-authored-by: Andres Uribe <andresuribe87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support generating generic JWK objects. Add validation so that it's impossible to generate signers/verifiers with unsupported key types/algorithms.