Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key type issue #255

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

andresuribe87
Copy link
Contributor

This PR exposes the key type used when decoding the DIDKey. This is needed as otherwise the information would be lost when decoding.

This is a prerequisite to fixing TBD54566975/ssi-service#181.

Note that I had to update some examples of the tests, since the test vectors appear to have been incorrectly generated.

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but may be cleaner as a new receiver method on DIDKey that is just GetKeyType

@codecov-commenter
Copy link

Codecov Report

Merging #255 (cf4dd5f) into main (ecc1264) will increase coverage by 0.10%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   59.03%   59.13%   +0.10%     
==========================================
  Files          38       38              
  Lines        4459     4490      +31     
==========================================
+ Hits         2632     2655      +23     
- Misses       1407     1410       +3     
- Partials      420      425       +5     
Impacted Files Coverage Δ
did/util.go 51.58% <30.77%> (+1.58%) ⬆️
did/key.go 65.73% <67.31%> (+0.36%) ⬆️
did/peer.go 65.37% <100.00%> (ø)
did/web.go 68.42% <100.00%> (ø)

@andresuribe87 andresuribe87 merged commit 08ecb5a into TBD54566975:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants