Handling pointers in key conversion #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 58.84% 58.80% -0.04%
==========================================
Files 38 38
Lines 4514 4534 +20
==========================================
+ Hits 2656 2666 +10
- Misses 1432 1442 +10
Partials 426 426
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crypto.PublicKeyfrom the go-crypto package is of typeany. This means that users may pass in multiple different things, including pointers to the types of the keys.This PR adds support for these conversions, along with tests.