Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signing utilities for vc-jws, with the appropriate content type. #273

Merged
merged 5 commits into from
Jan 25, 2023

Conversation

andresuribe87
Copy link
Contributor

This fixes #272

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #273 (e10d309) into main (e1cd85d) will decrease coverage by 0.14%.
The diff coverage is 45.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   60.48%   60.34%   -0.14%     
==========================================
  Files          39       40       +1     
  Lines        4398     4440      +42     
==========================================
+ Hits         2660     2679      +19     
- Misses       1311     1328      +17     
- Partials      427      433       +6     
Impacted Files Coverage Δ
crypto/jwt.go 48.50% <0.00%> (-1.24%) ⬇️
credential/signing/jws.go 51.35% <51.35%> (ø)

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but I'm hesitant to start using it given it hasn't seen any consensus or adoption (yet) in the working group. I wonder if we could add a go build tag for "experimental" or similar.

@andresuribe87
Copy link
Contributor Author

I wonder if we could add a go build tag for "experimental" or similar.

We could do this. A simpler approach would be to make that known in the godoc of the functions introduced. Thoughts?

@decentralgabe
Copy link
Member

agree with that

@andresuribe87 andresuribe87 merged commit cefec3d into TBD54566975:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptake VC Media Types
3 participants