cred manifest example #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
nitro-neal
reviewed
Jan 25, 2023
example/manifest/manifest.go
Outdated
| return did.GenerateDIDKey(crypto.Ed25519) | ||
| } | ||
|
|
||
| // Prepare a credential schema that will be issued to issue a credential from a successful Credential Manifest |
There was a problem hiding this comment.
nit:
// Prepare a credential schema that will be used to issue a credential from a successful Credential Manifest
nitro-neal
reviewed
Jan 25, 2023
example/manifest/manifest.go
Outdated
| return builder.Build() | ||
| } | ||
|
|
||
| // Prepare a credential which is required to fill out the credential manifest's application |
There was a problem hiding this comment.
nit:
// Prepare a credential which is required to fill out the credential manifest's application's input descriptor's requirements
nitro-neal
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.