Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable schema caching for tests #275

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Enable schema caching for tests #275

merged 3 commits into from
Jan 25, 2023

Conversation

andresuribe87
Copy link
Contributor

This makes tests run significantly faster. See below, where:

  • Before changes: 32.108
  • After changes: 11.448
➜  ssi-sdk git:(main) go clean -testcache; time go test -tags=jwx_es256k ./...             
ok      github.com/TBD54566975/ssi-sdk/credential       0.200s
ok      github.com/TBD54566975/ssi-sdk/credential/exchange      5.440s
ok      github.com/TBD54566975/ssi-sdk/credential/manifest      31.147s
ok      github.com/TBD54566975/ssi-sdk/credential/rendering     0.293s
ok      github.com/TBD54566975/ssi-sdk/credential/schema        0.342s
ok      github.com/TBD54566975/ssi-sdk/credential/signing       0.474s
ok      github.com/TBD54566975/ssi-sdk/credential/status        0.228s
ok      github.com/TBD54566975/ssi-sdk/credential/util  1.248s
ok      github.com/TBD54566975/ssi-sdk/credential/verification  0.409s
ok      github.com/TBD54566975/ssi-sdk/crypto   1.265s
ok      github.com/TBD54566975/ssi-sdk/cryptosuite      10.382s
ok      github.com/TBD54566975/ssi-sdk/did      1.534s
ok      github.com/TBD54566975/ssi-sdk/error    0.598s
ok      github.com/TBD54566975/ssi-sdk/example  0.634s
ok      github.com/TBD54566975/ssi-sdk/example/did      0.619s
ok      github.com/TBD54566975/ssi-sdk/example/presentation     0.539s
ok      github.com/TBD54566975/ssi-sdk/example/usecase/apartment_application    0.805s
ok      github.com/TBD54566975/ssi-sdk/example/usecase/employer_university_flow 0.365s
?       github.com/TBD54566975/ssi-sdk/example/usecase/employer_university_flow/pkg     [no test files]
ok      github.com/TBD54566975/ssi-sdk/example/usecase/steel_thread     1.094s
ok      github.com/TBD54566975/ssi-sdk/example/vc       0.156s
ok      github.com/TBD54566975/ssi-sdk/schema   0.332s
ok      github.com/TBD54566975/ssi-sdk/util     1.482s
?       github.com/TBD54566975/ssi-sdk/wasm/webserver   [no test files]
go test -tags=jwx_es256k ./...  10.23s user 2.37s system 39% cpu 32.108 total
➜  ssi-sdk git:(main) git stash pop
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   credential/manifest/schema_test.go

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (f2afd62511f6739149aac43a62a27a8dc4c08cf2)
➜  ssi-sdk git:(main) ✗ go clean -testcache; time go test -tags=jwx_es256k ./...
ok      github.com/TBD54566975/ssi-sdk/credential       0.266s
ok      github.com/TBD54566975/ssi-sdk/credential/exchange      5.787s
ok      github.com/TBD54566975/ssi-sdk/credential/manifest      0.962s
ok      github.com/TBD54566975/ssi-sdk/credential/rendering     0.136s
ok      github.com/TBD54566975/ssi-sdk/credential/schema        0.340s
ok      github.com/TBD54566975/ssi-sdk/credential/signing       0.439s
ok      github.com/TBD54566975/ssi-sdk/credential/status        0.208s
ok      github.com/TBD54566975/ssi-sdk/credential/util  1.182s
ok      github.com/TBD54566975/ssi-sdk/credential/verification  0.697s
ok      github.com/TBD54566975/ssi-sdk/crypto   0.747s
ok      github.com/TBD54566975/ssi-sdk/cryptosuite      10.721s
ok      github.com/TBD54566975/ssi-sdk/did      1.186s
ok      github.com/TBD54566975/ssi-sdk/error    0.602s
ok      github.com/TBD54566975/ssi-sdk/example  0.649s
ok      github.com/TBD54566975/ssi-sdk/example/did      0.532s
ok      github.com/TBD54566975/ssi-sdk/example/presentation     0.308s
ok      github.com/TBD54566975/ssi-sdk/example/usecase/apartment_application    0.809s
ok      github.com/TBD54566975/ssi-sdk/example/usecase/employer_university_flow 0.431s
?       github.com/TBD54566975/ssi-sdk/example/usecase/employer_university_flow/pkg     [no test files]
ok      github.com/TBD54566975/ssi-sdk/example/usecase/steel_thread     1.232s
ok      github.com/TBD54566975/ssi-sdk/example/vc       0.203s
ok      github.com/TBD54566975/ssi-sdk/schema   0.272s
ok      github.com/TBD54566975/ssi-sdk/util     1.557s
?       github.com/TBD54566975/ssi-sdk/wasm/webserver   [no test files]
go test -tags=jwx_es256k ./...  7.89s user 1.82s system 84% cpu 11.448 total

decentralgabe
decentralgabe reviewed Jan 25, 2023
View reviewed changes
credential/manifest/schema_test.go Outdated
if _, err = schema.NewCachingLoader(localSchemas); err != nil {
loader, err := schema.NewCachingLoader(localSchemas)
if err != nil {
println(err)
Copy link
Member

@decentralgabe decentralgabe Jan 25, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider logrus.WithError(err).Fatal()

decentralgabe
decentralgabe approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so fast so speedy

nitro-neal
nitro-neal approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@andresuribe87 andresuribe87 merged commit e1cd85d into TBD54566975:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitro-neal nitro-neal nitro-neal approved these changes

@decentralgabe decentralgabe decentralgabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andresuribe87 @nitro-neal @decentralgabe