adding statuslist conversion #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
decentralgabe and
andresuribe87
as code owners
decentralgabe
approved these changes
Jan 31, 2023
andresuribe87
approved these changes
Jan 31, 2023
credential/status/statuslist2021.go
Outdated
| @@ -303,3 +303,25 @@ func ValidateCredentialInStatusList(credentialToValidate credential.VerifiableCr | |||
| } | |||
| return false, nil | |||
| } | |||
|
|
|||
| func ToStatusList2021Entry(credStatus interface{}) (*StatusList2021Entry, bool) { | |||
There was a problem hiding this comment.
Suggested change
| func ToStatusList2021Entry(credStatus interface{}) (*StatusList2021Entry, bool) { | |
| func toStatusList2021Entry(credStatus interface{}) (*StatusList2021Entry, bool) { |
| @@ -252,7 +252,7 @@ func bitstringExpansion(compressedBitstring string) ([]string, error) { | |||
| // NOTE: this method does perform credential signature/proof block verification | |||
| func ValidateCredentialInStatusList(credentialToValidate credential.VerifiableCredential, statusCredential credential.VerifiableCredential) (bool, error) { | |||
There was a problem hiding this comment.
Can you update the godoc?
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 60.34% 60.43% +0.09%
==========================================
Files 40 40
Lines 4440 4458 +18
==========================================
+ Hits 2679 2694 +15
- Misses 1328 1330 +2
- Partials 433 434 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to use a StatusList2021Entry or a map[string]interface as our credStatus object.