-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uptake latest go #294
Uptake latest go #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you intending to replace the crypto/elliptic
occurrences in a different PR?
crypto/bbs.go
Outdated
// GenerateBBSKeyPair https://w3c-ccg.github.io/ldp-bbs2020 | ||
func GenerateBBSKeyPair() (*bbs.PublicKey, *bbs.PrivateKey, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to have this be part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
6844918
to
8cbde21
Compare
@andresuribe87 the update is for |
@decentralgabe I was thinking of the crypto/keys.go file as below Line 93 in d48966d
|
Since we're not using ECDH (just ECDSA for now) there aren't any code changes to make. When/if we uptake ECDH we'll make use of this package. |
Fixes #291