Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptake latest go #294

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Uptake latest go #294

merged 2 commits into from
Feb 28, 2023

Conversation

decentralgabe
Copy link
Member

Fixes #291

andresuribe87
andresuribe87 reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@andresuribe87 andresuribe87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you intending to replace the crypto/elliptic occurrences in a different PR?

crypto/bbs.go Outdated
Comment on lines 10 to 11
// GenerateBBSKeyPair https://w3c-ccg.github.io/ldp-bbs2020
func GenerateBBSKeyPair() (*bbs.PublicKey, *bbs.PrivateKey, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to have this be part of this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

@decentralgabe
Copy link
Member Author

@andresuribe87 the update is for The new [crypto/ecdh](https://go.dev/pkg/crypto/ecdh) package provides explicit support for Elliptic Curve Diffie-Hellman key exchanges over NIST curves and Curve25519. the code we have doesn't use ECDH

@andresuribe87
Copy link
Contributor

@decentralgabe I was thinking of the crypto/keys.go file as below

ssi-sdk/crypto/keys.go

Line 93 in d48966d

x, y := elliptic.Unmarshal(elliptic.P256(), keyBytes)
?

@decentralgabe
Copy link
Member Author

https://go.dev/pkg/crypto/ecdh

Since we're not using ECDH (just ECDSA for now) there aren't any code changes to make. When/if we uptake ECDH we'll make use of this package.

@decentralgabe decentralgabe merged commit 1223291 into main Feb 28, 2023
@decentralgabe decentralgabe deleted the uptake-latest-go branch February 28, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresuribe87 andresuribe87 andresuribe87 approved these changes

@nitro-neal nitro-neal Awaiting requested review from nitro-neal nitro-neal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uptake go1.20+
2 participants
@decentralgabe @andresuribe87