Added style and best practices #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decentralgabe PTAL |
decentralgabe
approved these changes
Mar 16, 2023
decentralgabe
pushed a commit
that referenced
this pull request
Mar 19, 2023
* Added style and best practices * nits deactivate request update request recover lint test not passing fix test fix reveal value; update test temp
decentralgabe
pushed a commit
that referenced
this pull request
Mar 19, 2023
* Added style and best practices * nits deactivate request update request recover lint test not passing fix test fix reveal value; update test temp
decentralgabe
added a commit
that referenced
this pull request
Mar 20, 2023
* Add models for Credential Issuer Metadata (#304) * Add simple URL for parsing strings. * Add credential issuer metadata for oidc. * Make the linter happy * PR feedback * Finish comment * More PR comments * Even More PR comments * Enforce unique CredentialsSupported.ID ion models long form did and initial request * Added style and best practices (#298) * Added style and best practices * nits deactivate request update request recover lint test not passing fix test fix reveal value; update test temp * update to jwx v2 * jwx 2 * bug fix * works * lint * update err messages * consistent spelling * pr errs --------- Co-authored-by: Andres Uribe <auribe@tbd.email>
decentralgabe
added a commit
that referenced
this pull request
Mar 21, 2023
* origin/main: Bump github.com/multiformats/go-multibase from 0.1.1 to 0.2.0 (#313) Bump github.com/go-playground/validator/v10 from 10.11.2 to 10.12.0 (#311) Bump github.com/goccy/go-json from 0.10.0 to 0.10.2 (#310) Bump golang.org/x/term from 0.5.0 to 0.6.0 (#299) Update JWX lib to use v2 (#308) Added style and best practices (#298) Add models for Credential Issuer Metadata (#304) Upgrade go version to 1.20.2 (#305) add missing param (#297) interface to any (#296) # Conflicts: # cryptosuite/cryptosuite.go # cryptosuite/jsonwebkey2020.go # cryptosuite/jwssignaturesuite.go # cryptosuite/jwssignaturesuite_test.go # go.mod # go.sum # util/helpers.go # wasm/static/main.wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #290