add context to resolver #329
Conversation
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
|
will uptake #329 before merge |
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 57.16% 57.16%
=======================================
Files 51 51
Lines 6148 6148
=======================================
Hits 3514 3514
Misses 1974 1974
Partials 660 660
|
did/key_fuzz_test.go
Outdated
| @@ -46,7 +47,7 @@ func FuzzCreateAndResolve(f *testing.F) { | |||
| didKey, err := CreateDIDKey(kt, pubKey) | |||
| assert.NoError(t, err) | |||
|
|
|||
| doc, err := resolver.Resolve(didKey.String()) | |||
| doc, err := resolver.Resolve(context.TODO(), didKey.String()) | |||
There was a problem hiding this comment.
Here and elsewhere. Using TODO signals that the context isn't ready, or unavailable. Did you consider using Background()?
| doc, err := resolver.Resolve(context.TODO(), didKey.String()) | |
| doc, err := resolver.Resolve(context.Background(), didKey.String()) |
There was a problem hiding this comment.
historically I had used TODO for tests to signify it's not a real context, but happy to switch.
| // ResolutionOptions https://www.w3.org/TR/did-spec-registries/#did-resolution-options | ||
| type ResolutionOptions any | ||
| // ResolutionOption https://www.w3.org/TR/did-spec-registries/#did-resolution-options | ||
| type ResolutionOption any |
There was a problem hiding this comment.
Whenever I see any, it's typically a symptom of an API that hasn't been fleshed out yet. In this case, it's unclear the shape of what ResolutionOption is acceptable by the functions that use it.
Instead, I would define an interface. Mind creating an issue to address?
Separately, This doesn't seem to be used anywhere.
There was a problem hiding this comment.
yeah not used anywhere yet...will create an issue
|
addressed all comments - switched all TODO to Background |
unifies resolution interface between the sdk and service