Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi method resolver #332

Merged
merged 3 commits into from
Mar 28, 2023
Merged

multi method resolver #332

merged 3 commits into from
Mar 28, 2023

Conversation

decentralgabe
Copy link
Member

update the resolver interface to support multiple methods per resolver as an option.
enforced interface compliance for resolvers in the sdk.

Copy link
Contributor

@andresuribe87 andresuribe87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion

did/resolver.go Outdated Show resolved Hide resolved
Co-authored-by: Andres Uribe <auribe@tbd.email>
@codecov-commenter
Copy link

Codecov Report

Merging #332 (29ae6ab) into main (a9e587d) will increase coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   57.16%   57.16%   +0.01%     
==========================================
  Files          51       51              
  Lines        6148     6149       +1     
==========================================
+ Hits         3514     3515       +1     
  Misses       1974     1974              
  Partials      660      660              
Impacted Files Coverage Δ
did/resolver.go 62.50% <62.50%> (+0.80%) ⬆️
did/key.go 72.87% <100.00%> (ø)
did/peer.go 65.58% <100.00%> (ø)
did/pkh.go 73.10% <100.00%> (ø)
did/web.go 70.34% <100.00%> (ø)

@decentralgabe decentralgabe merged commit 0ce55b2 into main Mar 28, 2023
@decentralgabe decentralgabe deleted the fix-multi-method-resolver branch March 28, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants