Get Key from a DID's Verification Information #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
decentralgabe
commented
Apr 7, 2023
decentralgabe
commented
- Already existed in a lesser from in the service, this will be uptaken there
nitro-neal
approved these changes
Apr 7, 2023
did/util.go
Outdated
|
|
||
| for _, method := range verificationMethods { | ||
| methodID := method.ID | ||
| maybeKID1 := kid // the kid == the kid |
There was a problem hiding this comment.
a helper function may make these look nicer
did/util.go
Outdated
| // resolution will fail. | ||
| // A KID can be fully qualified (e.g. did:example:123#key-1) or just the fragment (e.g. key-1, #key-1) | ||
| // Some DIDs, like did:key, use the entire DID as the KID, so we need to handle all three cases. | ||
| func GetKeyFromVerificationInformation(did Document, kid string) (gocrypto.PublicKey, error) { |
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 57.32% 57.48% +0.16%
==========================================
Files 51 51
Lines 6232 6298 +66
==========================================
+ Hits 3572 3620 +48
- Misses 1983 1998 +15
- Partials 677 680 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.