Credential Builder #37
Conversation
|
May add some more tests before merge. I'm happy that the tests pass against the spec's example. |
|
Added tests for the builder |
| @@ -414,7 +417,7 @@ func (v JSONWebKeyVerifier) Verify(message, signature []byte) error { | |||
| return err | |||
| } | |||
|
|
|||
| func NewJSONWebKeyVerifier(key PublicKeyJWK) (*JSONWebKeyVerifier, error) { | |||
| func NewJSONWebKeyVerifier(kid string, key PublicKeyJWK) (*JSONWebKeyVerifier, error) { | |||
There was a problem hiding this comment.
What was the reasoning behind including kid as a requirement?
There was a problem hiding this comment.
for linked data things, there's an expected verificationMethod that indicates a key-reference in a DID, or another URI-resolvable document; this is only required for the signer. The verifier technically does not need this; however, the JWK library we use requires the kid in the public key you construct to match the kid in the signed message you're verifying...which is why on this specific verifier it's a required parameter.
| // create proof before CVH | ||
| proof := j.createProof(s.KeyID()) | ||
|
|
||
| // prepare proof options | ||
| contexts, err := GetContextsFromProvable(p) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "could not get contexts from provable") | ||
| return errors.Wrap(err, "could not get contexts from provable") |
| "testing" | ||
|
|
||
| "github.com/goccy/go-json" |
There was a problem hiding this comment.
solid choice! being able to pass Context.context into Marshal and Unmarshal is awesome
vc/credential.go
Outdated
| @@ -0,0 +1,236 @@ | |||
| package vc | |||
There was a problem hiding this comment.
I think it'd be helpful to include package level documentation (reference). Can also use the doc.go convention
vc/credential.go
Outdated
| @@ -0,0 +1,236 @@ | |||
| package vc | |||
There was a problem hiding this comment.
would it make more sense if this file was called builder.go given that's what's in it?
#31