include dilithium; clean up key types and related methods #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 59.28% 59.30% +0.02%
==========================================
Files 56 55 -1
Lines 6847 6840 -7
==========================================
- Hits 4059 4056 -3
+ Misses 2076 2074 -2
+ Partials 712 710 -2
|
andresuribe87
approved these changes
May 5, 2023
crypto/keys_test.go
Outdated
Comment on lines
141
to
182
| t.Run("Able to generate dilithium key pairs for each mode", func(tt *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| m dilithium.Mode | ||
| wantErr bool | ||
| }{ | ||
| { | ||
| "mode2", | ||
| dilithium.Mode2, | ||
| false, | ||
| }, | ||
| { | ||
| "mode3", | ||
| dilithium.Mode3, | ||
| false, | ||
| }, | ||
| { | ||
| "mode5", | ||
| dilithium.Mode5, | ||
| false, | ||
| }, | ||
| { | ||
| "bad", | ||
| nil, | ||
| true, | ||
| }, | ||
| } | ||
| for _, test := range tests { | ||
| tt.Run(test.name, func(ttt *testing.T) { | ||
| pk, sk, err := GenerateDilithiumKeyPair(test.m) | ||
| if test.wantErr { | ||
| assert.Error(ttt, err) | ||
| assert.Nil(ttt, pk) | ||
| assert.Nil(ttt, sk) | ||
| } else { | ||
| assert.NoError(ttt, err) | ||
| assert.NotNil(ttt, pk) | ||
| assert.NotNil(ttt, sk) | ||
| } | ||
| }) | ||
| } | ||
| }) |
There was a problem hiding this comment.
nit: minimize branching logic inside tests. In this case I suggest separating the error case behavior into a separate test. It would make things more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.